Use Rust FFI #12: Binary #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienvx
force-pushed
the
binary
branch
4 times, most recently
from
467aca1 to
dbb79ec
Compare
YOU54F
reviewed
Sep 11, 2023
| $response | ||
| ->setStatus(200) | ||
| ->addHeader('Content-Type', 'image/jpeg') | ||
| ->setBody(new Binary($imageContent, in_array(php_uname('m'), ['AMD64', 'arm64']) ? 'application/octet-stream' : 'image/jpeg')); |
There was a problem hiding this comment.
Related to pact-foundation/pact-reference#305 I presume
There was a problem hiding this comment.
I think pact-foundation/pact-reference#171 is more precise
YOU54F
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Looks good dude, I do like the separation of the examples by function, as it's not clear for example from pact-js v3 folder
https://github.com/pact-foundation/pact-js/tree/master/examples/v3
as to the fact the to-do consumer is the xml project (i know it says elsewhere but there folders could be desrcription). food for thought as we begin to align project examples to had a common scenario and reference to then have a sample test in each language)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary file support with example.
This PR depends on #331. Please review it first.