Use Rust FFI #13: Multipart #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
reviewed
Sep 11, 2023
YOU54F
reviewed
Sep 11, 2023
YOU54F
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Looks good, couple of minor comments,
We should put a note about the content-type matching as well, and note the workaround in the test so the users can consider if they require the same for their own tests.
(I'm not sure of the value of testing say your production code, x plat, if the provider for example will only run in prod on a specific os)
|
happy to fix forward on the comments above ☝🏾 re documentation, in the upgrade guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multipart body support with example.
This PR depends on #332. Please review it first.
This PR depends on this bug to be fixed first.