New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node): get `test-assert.js` working #15698

Draft

DonIsaac wants to merge 10 commits into main from don/test/test-assert

+3,707 −1,259

Contributor

DonIsaac commented Dec 11, 2024 •

edited

Loading

What does this PR do?

Overhauls node:assert to better match node's behavior
Adds test-assert.js to the list of passing node test cases

Upstack from #15697

How did you verify your code works?

I ported node test cases.

robobun commented Dec 11, 2024 •

edited

Loading

❌ Your commit 0144be6 has 12 failures in #7936:

test/js/bun/http/serve.test.ts - 2 failing on 🍎 14 x64

test/js/bun/http/serve.test.ts - 2 failing on 🍎 13 x64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64

test/v8/v8.test.ts - timeout on 🐧 22.04 aarch64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 aarch64

test/cli/run/require-cache.test.ts - 1 failing on 🐧 24.04 x64

test/cli/run/require-cache.test.ts - 1 failing on 🐧 12 x64

test/cli/run/require-cache.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/cli/run/require-cache.test.ts - 1 failing on 🐧 3.20 aarch64

test/cli/run/require-cache.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/cli/run/require-cache.test.ts - 1 failing on 🍎 14 x64

test/cli/run/require-cache.test.ts - 1 failing on 🍎 13 x64

test/js/node/test/parallel/test-async-hooks-worker-asyncfn-terminate-4.js - code 1 on 🐧 20.04 aarch64

test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 20.04 aarch64

test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 3.20 aarch64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 aarch64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 x64-baseline

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 14 x64

test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64-baseline

test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64

test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 3.20 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-assert.js - code 1 on 🐧 3.20 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 3.20 x64

test/js/node/test/parallel/test-assert-builtins-not-read-from-filesystem.js - code 1 on 🐧 3.20 x64-baseline

DonIsaac marked this pull request as draft

December 11, 2024 04:03

Base automatically changed from 12-10-build_trigger_cpp_build_when_generated_errorcode_files_change to 12-10-test_mock_node_test_module_in_node_test_harness

December 11, 2024 04:36

Don Isaac added 2 commits

December 10, 2024 20:56


          test(node): get test-assert.js working

d201278


          update tests

bdd3d15

DonIsaac changed the base branch from 12-10-test_mock_node_test_module_in_node_test_harness to main

December 11, 2024 04:56

DonIsaac force-pushed the don/test/test-assert branch from 710cbf7 to bdd3d15 Compare

December 11, 2024 04:56

Don Isaac and others added 2 commits

December 11, 2024 21:25


          Merge branch 'main' of github.com:oven-sh/bun into don/test/test-assert

f7cb4fc


          Merge branch 'main' into don/test/test-assert

dcd0d0d

DonIsaac marked this pull request as ready for review

December 12, 2024 06:20

DonIsaac requested review from paperdave and Jarred-Sumner

December 12, 2024 06:20

Jarred-Sumner marked this pull request as draft

December 12, 2024 09:51

Don Isaac added 2 commits

December 12, 2024 10:17


          Merge branch 'main' of github.com:oven-sh/bun into don/test/test-assert

d14fb27


          Merge branch 'don/test/test-assert' of github.com:oven-sh/bun into do…

23635fc

…n/test/test-assert

DonIsaac mentioned this pull request

feat: add JSObject constructors #15742

Merged

Don Isaac and others added 4 commits

December 12, 2024 21:18


          Use native myers diff algorithm.

dc8110f

`Diff` still needs serializing. Blocked by #15742.


          bun run zig-format

3b7a89d

wip

aa5245f


          Merge branch 'main' of github.com:oven-sh/bun into don/test/test-assert

0144be6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet