Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JSObject constructors #15742

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

  • Add constructors to JSObject for marshalling structs
  • Refactor some existing code to use them

How did you verify your code works?

Code change affects existing code; I ran the tests.

@robobun
Copy link

robobun commented Dec 13, 2024

@DonIsaac, your commit eed2b01 has 10 failures in #7929:

  • test/js/bun/http/serve.test.ts - 2 failing on 🍎 14 x64
  • test/js/bun/http/serve.test.ts - 2 failing on 🍎 13 x64
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🐧 22.04 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 12 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 3.20 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🍎 14 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🍎 13 x64
  • test/js/node/dns/node-dns.test.js - 1 failing on 🪟 2019 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 13 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 14 aarch64
  • @DonIsaac
    Copy link
    Contributor Author

    Prereq for #15698

    Copy link
    Member

    @paperdave paperdave left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    realizing this means createEmptyObject(0) -> JSObject.create(.{})

    i'll write documentation for $bindgenFn

    DonIsaac pushed a commit that referenced this pull request Dec 13, 2024
    `Diff` still needs serializing. Blocked by #15742.
    @Jarred-Sumner Jarred-Sumner merged commit bd1c5e9 into main Dec 13, 2024
    64 of 67 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the don/feat/object-create-pojo branch December 13, 2024 06:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants