Prove that semantic matching of given expressions already works
#8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The `model` package is reserved for classes that are part of the SPDX document model, but `SpdxLicenseChoice` is an ORT model class. Signed-off-by: Sebastian Schuberth <[email protected]>
This tests the same scenario as the "return the new expression if only a part of the expression is matched by the subExpression" test. Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8175 +/- ##
=========================================
Coverage 67.16% 67.16%
+ Complexity 2052 2049 -3
=========================================
Files 358 357 -1
Lines 17166 17158 -8
Branches 2462 2461 -1
=========================================
- Hits 11530 11525 -5
+ Misses 4613 4611 -2
+ Partials 1023 1022 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ions Resolves #7186. Signed-off-by: Sebastian Schuberth <[email protected]>
This avoids potentially expensive `validChoices()` calls on literal expression matches. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
spdx-license-choice-imps
branch
from
801f1a8 to
2dd79a4
Compare
fviernau
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
Note
Breaking change: Programmatic use needs to update
import org.ossreviewtoolkit.utils.spdx.model.SpdxLicenseChoicetoimport org.ossreviewtoolkit.utils.spdx.SpdxLicenseChoice.