perf(spdx-utils): Make the cheap check go first

This avoids potentially expensive `validChoices()` calls on literal expression matches. Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Jan 25, 2024 · 2dd79a4 · 2dd79a4
1 parent 96c8b19
commit 2dd79a4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/utils/spdx/src/main/kotlin/SpdxExpression.kt b/utils/spdx/src/main/kotlin/SpdxExpression.kt
@@ -336,7 +336,7 @@ class SpdxCompoundExpression(
         val expressionString = toString()
         val subExpressionString = subExpression.toString()
 
-        return validChoices().containsAll(subExpression.validChoices()) || subExpressionString in expressionString
+        return subExpressionString in expressionString || validChoices().containsAll(subExpression.validChoices())
     }
 
     override fun equals(other: Any?): Boolean {