Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CompareCommand): Implement missing comparisons for the SEMANTIC_DIFF method #7946

Closed
wants to merge 10 commits into from

Conversation

bs-ondem
Copy link
Member

Check individual commit messages for details.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaa29e5) 67.01% compared to head (47c1c0c) 67.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7946   +/-   ##
=========================================
  Coverage     67.01%   67.01%           
  Complexity     2054     2054           
=========================================
  Files           357      357           
  Lines         17083    17083           
  Branches       2449     2449           
=========================================
  Hits          11448    11448           
  Misses         4614     4614           
  Partials       1021     1021           
Flag Coverage Δ
funTest-non-docker 34.32% <ø> (ø)
test 36.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bs-ondem bs-ondem force-pushed the semantic_compare2 branch 2 times, most recently from 2c17e5d to 271782b Compare December 7, 2023 10:28
bs-ondem and others added 8 commits December 8, 2023 08:14
This commit adds new data classes to track the differences of the two ORT
results and especially of two repositories.

Signed-off-by: Onur Demirci <[email protected]>
This commit includes the data classes to track the differences of the
`AnalyzerRun`s and adds it to the `OrtResultDiff` class.

Signed-off-by: Onur Demirci <[email protected]>
Allow for some lenient comparisons and print only differences in
license and snippet findings.

Signed-off-by: Oliver Heger <[email protected]>
Improve the handling of resolved package curations in the
`CompareCommand` by building a diff of the curations for each provider.

Signed-off-by: Martin Nonnenmacher <[email protected]>
If the scanners used for the packages are different, only show the
entries that actually are different, not the whole lists.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher
Copy link
Member

I'm closing this PR as there are currently no plans to continue working on it from our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants