Do not use sorted sets for package references in Scope and PackageReferences
#7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fviernau
force-pushed
the
scope-no-sorted-set
branch
2 times, most recently
from
9ae37e2
to
1a8f2d0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7010 +/- ##
============================================
- Coverage 64.28% 64.26% -0.03%
+ Complexity 1976 1974 -2
============================================
Files 332 333 +1
Lines 16734 16741 +7
Branches 2382 2381 -1
============================================
+ Hits 10758 10759 +1
- Misses 4937 4943 +6
Partials 1039 1039
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
scope-no-sorted-set
branch
from
1a8f2d0
to
fe71880
Compare
fviernau
force-pushed
the
scope-no-sorted-set
branch
6 times, most recently
from
ad38729
to
ba64a24
Compare
sschuberth
requested changes
May 22, 2023
plugins/reporters/evaluated-model/src/main/kotlin/EvaluatedModelMapper.kt
Outdated
Show resolved
Hide resolved
fviernau
force-pushed
the
scope-no-sorted-set
branch
from
ba64a24
to
52c1974
Compare
sschuberth
approved these changes
May 23, 2023
Simplify an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
The order in which the direct dependencies of each tree node are listed does not matter. It does matter that the trees are equivalent. Adjust `scopeDependencies()` and `dumpDependencies()` to produce a deterministic result by using sorted order of children for the conversion to `String`. Signed-off-by: Frank Viernau <[email protected]>
Do not assert the order of the direct dependencies. Signed-off-by: Frank Viernau <[email protected]>
This simplifies an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Make the output more deterministics and independent of the ordering of the input. This simplifies an upcoming change. Part of #7023. Signed-off-by: Frank Viernau <[email protected]>
The previous assertion was asserting too much, because only equality of the JSON is required but the order of the elements does not matter. Relax the asserting also to simplify an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
scope-no-sorted-set
branch
from
52c1974
to
d315321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #6235 .