refactor(Conan): Utilize buildSet() in parseDependencyTree()

Signed-off-by: Frank Viernau <[email protected]>
oss-review-toolkit · May 17, 2023 · 9ae37e2 · 9ae37e2
1 parent 3363a22
commit 9ae37e2
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/plugins/package-managers/conan/src/main/kotlin/Conan.kt b/plugins/package-managers/conan/src/main/kotlin/Conan.kt
@@ -267,25 +267,22 @@ class Conan(
         pkg: JsonNode,
         scopeName: String,
         workingDir: File
-    ): Set<PackageReference> {
-        val result = mutableSetOf<PackageReference>()
-
-        pkg[scopeName]?.forEach { childNode ->
-            val childRef = childNode.textValueOrEmpty()
-            pkgInfos.find { it["reference"].textValueOrEmpty() == childRef }?.let { pkgInfo ->
-                logger.debug { "Found child '$childRef'." }
+    ): Set<PackageReference> =
+        buildSet {
+            pkg[scopeName]?.forEach { childNode ->
+                val childRef = childNode.textValueOrEmpty()
+                pkgInfos.find { it["reference"].textValueOrEmpty() == childRef }?.let { pkgInfo ->
+                    logger.debug { "Found child '$childRef'." }
 
-                val id = parsePackageId(pkgInfo, workingDir)
-                val dependencies = parseDependencyTree(pkgInfos, pkgInfo, SCOPE_NAME_DEPENDENCIES, workingDir) +
-                        parseDependencyTree(pkgInfos, pkgInfo, SCOPE_NAME_DEV_DEPENDENCIES, workingDir)
+                    val id = parsePackageId(pkgInfo, workingDir)
+                    val dependencies = parseDependencyTree(pkgInfos, pkgInfo, SCOPE_NAME_DEPENDENCIES, workingDir) +
+                            parseDependencyTree(pkgInfos, pkgInfo, SCOPE_NAME_DEV_DEPENDENCIES, workingDir)
 
-                result += PackageReference(id, dependencies = dependencies)
+                    this += PackageReference(id, dependencies = dependencies)
+                }
             }
         }
 
-        return result
-    }
-
     /**
      * Run through each package and parse the list of its dependencies (also transitive ones).
      */