Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metrics to observability #2759

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat: Add metrics to observability #2759

merged 1 commit into from
Mar 15, 2023

Conversation

mimotej
Copy link
Member

@mimotej mimotej commented Mar 9, 2023

This PR adds new metrics to be gathered by the MCO observability
Part of: operate-first/service-catalog#68

@mimotej
Copy link
Member Author

mimotej commented Mar 9, 2023

/cc @tumido

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
@sesheta sesheta requested a review from tumido March 9, 2023 15:16
@mimotej
Copy link
Member Author

mimotej commented Mar 9, 2023

/retest

@mimotej mimotej force-pushed the add-mapi_machine_created_timestamp_seconds-metrics branch from 0b72d26 to a9c1dfa Compare March 9, 2023 15:35
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2023
tumido
tumido approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2023
@mimotej
Copy link
Member Author

mimotej commented Mar 9, 2023

/retest

@mimotej mimotej force-pushed the add-mapi_machine_created_timestamp_seconds-metrics branch from a9c1dfa to 947c661 Compare March 9, 2023 16:51
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
tumido
tumido approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@mimotej mimotej force-pushed the add-mapi_machine_created_timestamp_seconds-metrics branch from 947c661 to fc31c1f Compare March 9, 2023 16:56
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@mimotej mimotej requested a review from tumido March 9, 2023 17:01
@mimotej
Copy link
Member Author

mimotej commented Mar 10, 2023

/retest

2 similar comments
@mimotej
Copy link
Member Author

mimotej commented Mar 13, 2023

/retest

@mimotej
Copy link
Member Author

mimotej commented Mar 13, 2023

/retest

@mimotej mimotej mentioned this pull request Mar 13, 2023
Merged
@mimotej mimotej force-pushed the add-mapi_machine_created_timestamp_seconds-metrics branch from fc31c1f to 78e2eae Compare March 13, 2023 10:52
@mimotej mimotej mentioned this pull request Mar 15, 2023
Merged
@tumido
Copy link
Member

tumido commented Mar 15, 2023

/retest

tumido
tumido approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@sesheta
Copy link
Member

sesheta commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 52c03cd into operate-first:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimotej @tumido @sesheta