fix: Increase kubeval job memory request to 4GB #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Drla <[email protected]>
sesheta
added
the
size/XS
|
/cc @tumido |
|
/lgtm |
|
/assign @tumido |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goern, tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the bump to 1 GB in #2761 does not seem to be enough (as can be seen in #2759, which is still being OOMKilled) and from testing which I did it seems that kubeval can use more than 2 GB, I am bumping this value to 4GB to have some reserve.
Reason why this is happening is that kubeval caches in memory schemas which it might need for the validation. These schemas are regularly updated in schema-store and I suspect that lately there has been some change that impacted size of the schemas dramatically. This means that also size that is cached increased.