UTIL: Add riscv64 support #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Sergei-Lebedev
approved these changes
Aug 28, 2023
shimmybalsam
approved these changes
Aug 28, 2023
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
from
7a7f41f to
36e04ca
Compare
|
@rbradford please add the new file you created to Makefile here: |
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
2 times, most recently
from
5abcee7 to
6a85f17
Compare
Fixed. Thank you! |
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
from
6a85f17 to
5e16b9a
Compare
|
@rbradford Have you signed CLA with UCF? Thanks. |
Yes, my employer (Rivos Inc) has signed the corporate CLA. |
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
2 times, most recently
from
2059aee to
5831a3f
Compare
|
Ping? Any update on this? |
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
from
5831a3f to
c6ff51d
Compare
manjugv
approved these changes
Sep 7, 2023
|
@rbradford please rebase |
Signed-off-by: Rob Bradford <[email protected]>
rbradford
force-pushed
the
2023-08-25-riscv64-port
branch
from
c6ff51d to
3bac9a7
Compare
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rob Bradford <[email protected]>
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rob Bradford <[email protected]>
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Rob Bradford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enables support for RISC-V (64-bit)
Why ?
UCX has recently gained support for this architecture so it would be nice to add UCC support
How ?
The changes needed to support just consist of implementing the fence functions using the fence instructions - the ones used here match added to UCX.