Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade ubuntu until playwright is upgraded #804

Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Ubuntu 24.04 is supported by a newer version of Playwright, but not the one we are using

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool how was this ever working? or did ubuntu-latest just get updated?

@miles-grant-ibigroup
Copy link
Collaborator Author

Yep! I think 24.10 got released/24.04 made it into GitHub actions

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Whats the process to upgrade playwright?

@miles-grant-ibigroup
Copy link
Collaborator Author

LGTM! Whats the process to upgrade playwright?

@daniel-heppner-ibigroup will know!

@miles-grant-ibigroup miles-grant-ibigroup merged commit dc74148 into opentripplanner:master Dec 26, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-ci-dec-24 branch December 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants