Add 'boundsFitting' prop to manage camera manipulation via zoomToGeoJSON method #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsage88
requested review from
miles-grant-ibigroup and
binh-dam-ibigroup
binh-dam-ibigroup
approved these changes
Dec 19, 2024
|
Blocked by #804. I'll review once that's merged. I have a feeling snapshots might have to get updated |
miles-grant-ibigroup
added
the
BLOCKERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a need for Trimet's instance of the maplibre map to not get the camera's placement hijacked by the zoomToGeoJSON method which is causing some issues with how we want to frame the transitive-overlay with respect to the side-panel we house much of our tools in.
Essentially, we pass in boundsFitting from the client and into packages/transitive-overlay/src/index.tsx. If it happens to be false then when zoomToGeoJSON is called then it returns immediately with no effect on the map. Since this was set up to be active by default, I made the boundsFitting prop be defaultly true.