feat(location-field): make location group order configurable #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
binh-dam-ibigroup
requested changes
Sep 9, 2024
| const OtherFeaturesHeader = () => ( | ||
| <S.MenuGroupHeader as={headingType} bgColor="#333" key="other-header"> | ||
| <FormattedMessage | ||
| description="Text for header above the 'other'" |
There was a problem hiding this comment.
Description looks unfinished, could you fix please?
…/otp-ui into reorder-other-to-first
|
Blocked by #774 |
amy-corson-ibigroup
added
the
BLOCKERS
amy-corson-ibigroup
removed
the
BLOCKERS
binh-dam-ibigroup
requested changes
Sep 13, 2024
| const [otherControl, setOtherControl] = useState(false); | ||
| return ( | ||
| <> | ||
| <label htmlFor="other-input"> |
There was a problem hiding this comment.
Could you make Storybook create the controls using argTypes instead? (Storybook will add that to its "Controls" tab - I should have mentioned that in my previous review but somehow thought you knew) Do that for this story only. Refer to e.g.
miles-grant-ibigroup
approved these changes
Oct 30, 2024
binh-dam-ibigroup
requested changes
Nov 1, 2024
|
@amy-corson-ibigroup Also please update the props in the PR description... |
binh-dam-ibigroup
approved these changes
Nov 12, 2024
|
Thanks @binh-dam-ibigroup and @miles-grant-ibigroup !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuration of the order of the returned location group results. Users can now pass a array of feature types using
geocoderResultsOrderto specify the order in which geocoder results are returned.