Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "geocoderResultsOrder" config item to LocationFields #1268

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

Makes use of opentripplanner/otp-ui#771

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@amy-corson-ibigroup amy-corson-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Sep 5, 2024
@amy-corson-ibigroup amy-corson-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Nov 20, 2024
@amy-corson-ibigroup amy-corson-ibigroup changed the title Pass "renderOtherFirst" config item to LocationFields Pass "geocoderResultsOrder" config item to LocationFields Nov 22, 2024
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! TY for the changes

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binh-dam-ibigroup
Copy link
Collaborator

Did someone break a11y tests?

@amy-corson-ibigroup
Copy link
Contributor Author

Did someone break a11y tests?

Oops just needed to handle if the geocoder config wasn't defined!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 3efbfc6 into dev Dec 10, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the pass-render-other-first branch December 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants