set viewedRouteStops when route viewer is active
#1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
added
the
BLOCKED
miles-grant-ibigroup
removed
the
BLOCKED
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
miles-grant-ibigroup
force-pushed
the
show-stops-in-route-viewer
branch
from
81eaa1e to
d9d4c97
Compare
daniel-heppner-ibigroup
requested changes
Sep 17, 2024
lib/components/map/default-map.tsx
Outdated
| state.otp?.transitIndex?.routes?.[viewedRoute]?.patterns || {} | ||
| ).reduce((acc, cur) => { | ||
| return Array.from( | ||
| new Set([...cur?.[1]?.stops.map((s) => s.id), ...acc]) |
There was a problem hiding this comment.
I think this can be cleaned up. Remove the Array.from and Set from this and do it outside the reducer so it doesn't have to be repeated on each loop. Also, maybe we can move this to a function above? I found it quite difficult to read what was happening here.
There was a problem hiding this comment.
Alternatively just break out more variables. Like put the Object.entries into a variable.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Merged
3 tasks
miles-grant-ibigroup
added
the
BLOCKED
|
Blocked by #1270 |
amy-corson-ibigroup
removed
the
BLOCKED
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Sep 23, 2024
amy-corson-ibigroup
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Blocked waiting for opentripplanner/otp-ui#772
PR Checklist: