Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otp-ui packages #1278

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Update otp-ui packages #1278

merged 4 commits into from
Sep 20, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

Update OTP-UI packages and fix imports

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@amy-corson-ibigroup
Copy link
Contributor Author

amy-corson-ibigroup commented Sep 18, 2024

Note that because the latest version of otp2-tile-overlay requires passing viewedRouteStops, I've added a null value that will need to be taken out in #1270 (I can add that commit)

The latest version of otp2-tile-overlay also contains fixes for stop popup focus traps and it seemed more beneficial to update the package now and provide this stop gap, rather than wait.

@miles-grant-ibigroup
Copy link
Collaborator

Note that because the latest version of otp2-tile-overlay requires passing viewedRouteStops, I've added a null value that will need to be taken out in #1270 (I can add that commit)

The latest version of otp2-tile-overlay also contains fixes for stop popup focus traps and it seemed more beneficial to update the package now and provide this stop gap, rather than wait.

OK I've blocked #1270. When this is merged please make the commit/let me know

@miles-grant-ibigroup
Copy link
Collaborator

Unit tests are failing because the latest version of transitive is broken. If you downgrade that the tests will pass

@amy-corson-ibigroup
Copy link
Contributor Author

@miles-grant-ibigroup jest was failing because newest version of transitive added a img file, I fixed it by adding a mock but can downgrade to 18 if we want! Let me know

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 9a56086 into dev Sep 20, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the update-packages-sept branch September 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants