Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apiV2): Pass batchId when calling GraphQL 'plan' endpoint #1252

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

Works in conjunction with ibi-group/otp-middleware#246.

This PR makes the UI pass a batchId parameter when making a call to the GraphQL plan endpoint, so that trip requests can be grouped as a single entry in the "Recent searches" list and in usage reports.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 8598089 into dev Aug 7, 2024
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the pass-batchid-to-graphql branch August 7, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants