Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Request batchId #246

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Handle Request batchId #246

merged 4 commits into from
Aug 26, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Aug 2, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

To be used with opentripplanner/otp-react-redux#1252.

This PR corrects the persistence of trip requests (for applicable users) by persisting the batchId parameter provided by the UI client instead of creating a batchId that is not related to the search performed in the UI.

Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Aug 5, 2024
@binh-dam-ibigroup binh-dam-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Aug 5, 2024
Base automatically changed from store-graphql-trip-requests to dev August 5, 2024 15:49
@binh-dam-ibigroup binh-dam-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Aug 5, 2024
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure a missing batchId doesn't cause a crash but otherwise this looks nice and clean!

@JymDyerIBI JymDyerIBI merged commit 2a87ce7 into dev Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants