feat: features OTCR natively in canary

[kokekanon]

6/6

for test use this client.exe https://github.com/mehah/otclient/actions/runs/11730256085
or use this in terminal

ProtocolGame.registerOpcode(0x43, function(protocol, msg)
    local count = msg:getU16()
    for i = 1, count do
      local feature = msg:getU8()
	  local enable = msg:getU8()
	  if enable == 1 then
		g_game.enableFeature(feature)
	  end
	end
end)

Description

Feature	Done	No break v8 or cipsoft
1.- Creature AE + Shader	✅	✅
2.- send disableFeature / enableFeature . easy to modify in config.lua	✅ mehah/otclient#962	✅
3.- outfit (wings,aura,shader)	✅	✅
4.- TypingIcon	✅	✅
5.- map shader support	✅	✅
6- item Shader	✅	✅

1.-Creature AE + Shader

no break cipsoft or v8

2.-send disableFeature / enableFeature . easy to modify in config.lua

it is easier for the server administrator to modify config.lua than to compile every time he wants to add or remove a feature.
note1: v8 and otcr send the same packets, so it could be only 1 function, but i don't want to break anything.

note2 : In otcr requires modification in the client * is not yet ready

3.- outfit (wings,aura,shader)

4.- TypingIcon

5.- map shader support

6.- item Shader

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested

1/6 Creature : AttachedEffect | Shader

Client:
--   g_game.enableFeature(GameCreatureAttachedEffect)
--   g_game.enableFeature(GameCreatureShader)
Server:
	player:setShader("Outfit - Rainbow")
	player:attachEffectById(7)
	player:attachEffectById(8)

2/6 Player: Map Shader

	player:setMapShader("Map - Party")

4/6 feature: Item Shader

--Client:
	g_game.enableFeature(GameItemShader)
-- Server:
	player:addItem(ITEM_BAG, 1, false, CONST_SLOT_BACKPACK):setShader("Map - Party")

5/6 send disableFeature / enableFeature. easy to modify in config.lua

const auto &enabledFeatures = g_configManager().getEnabledOTCFeatures();
const auto &disabledFeatures = g_configManager().getDisabledOTCFeatures();

for (auto feature : enabledFeatures) {
g_logger().info("Feature enabled: {}", feature);
}

for (auto feature : disabledFeatures) {
g_logger().info("Feature disabled: {}", feature);
}

6/6

x:addCustomOutfit("aura", 8)
x:removeCustomOutfit("aura", 8)

Test Configuration:

• Server Version: 13.40
• Client: OTCR
• Operating System: 11

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

Note: To be honest, I'm not good at C++, and I don't use Canary, I'm not used to the structure.

[dudantas]

Thank you for your contribution. I have a few observations that could help further improve the work.

[dudantas]

You can remove the & as well; passing a std::string_view by reference actually increases overhead. std::string_view is intended to be passed by value since it is simply a lightweight view of the string.

[dudantas]

Here, it will remain as std::string. std::string_view is used to avoid copying the string, but in the final context where it needs to be stored or modified, it must be a std::string.

[dudantas]

Apologies for the confusion. In the setShader method, you can continue using std::string_view, but for all other methods, they can remain as std::string.

PS: If you need, I can help commit.

[dudantas]

@kokekanon
I couldn't commit directly to your fork, but here's the commit if you want to cherry pick it
1437b7e

[kokekanon]

v8 old protocol no send "isMountRandomized" , last packet is newOutfit.lookMount = msg.get<uint16_t>(); canary read in (L1711)

https://github.com/opentibiabr/otcv8/blob/main/src/client/protocolgamesend.cpp#L833

Redemption 11.00 no send isMountRandomized only in 13.40

[kokekanon]

load this (sendCreatureOutfit and AddCreature) into AddOutfit
(same packets)

[kokekanon]

load this (sendCreatureOutfit and AddCreature) into AddOutfit
(same packets)

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.2% Duplication on New Code

See analysis details on SonarQube Cloud