Group partners by age #2685
Group partners by age #2685
Conversation
| @@ -0,0 +1,67 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
The functions didn't change much, but I extracted the Dialog to its own module, I moved the instance of the Dialog up a level to the Results, and of course added types. A side-by-side compare to the deleted result-grid.js would be useful.
| @@ -0,0 +1,300 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Again a side-by-side with results.js could be helpful.
There was a problem hiding this comment.
git mv would be nice for reviewing these
There was a problem hiding this comment.
It was git mvd in the first commit, but the number of changes made git treat it as delete and create.
| ); | ||
| const equityOptionValues = equityOptions.map((entry) => entry.value); | ||
|
|
||
| type PartnerData = { |
| }; | ||
| } | ||
|
|
||
| type Ages = '10' | '7' | '4' | '1' | 'new'; |
There was a problem hiding this comment.
These are the new groupings
| }; | ||
| } | ||
|
|
||
| function SeeMore({defaultOpen, children}) { |
There was a problem hiding this comment.
No longer using this
|
|
||
| type Ages = '10' | '7' | '4' | '1' | 'new'; | ||
|
|
||
| function ResultGridLoader({ |
There was a problem hiding this comment.
This was revamped to create the age groupings rather than the old groupings.
| import {useNavigate, useLocation} from 'react-router-dom'; | ||
| import type {LinkTexts, PartnerEntry} from './results'; | ||
|
|
||
| export default function SelectedPartnerDialog({ |
There was a problem hiding this comment.
Extracted these routines from result-grid, where they didn't really belong.
| @@ -41,7 +41,7 @@ describe('details/common/hooks', () => { | |||
|
|
|||
| render(<Component />); | |||
|
|
|||
| await screen.findByText('28,29,31,32,39,41,42,48,55,56,61,7,70,79,9'); | |||
| await screen.findByText('1938,1951,1955,1962,1984,2109'); | |||
There was a problem hiding this comment.
I had to update some test data files because the structures were out of date, so I have some new results for this test.
| rating={summary.rating} | ||
| count={summary.count} | ||
| showNumber /> | ||
| */} |
| @@ -0,0 +1,300 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
git mv would be nice for reviewing these
| @@ -1,7 +1,7 @@ | |||
| import {useState, useEffect} from 'react'; | |||
| import buildContext from '~/components/jsx-helpers/build-context'; | |||
|
|
|||
| function useContextValue(partner) { | |||
| function useContextValue(partner: unknown) { | |||
There was a problem hiding this comment.
Is this using the PartnerData type and could be annotated with it? I'm not sure how this get used
There was a problem hiding this comment.
dialog-context provides info about the selected Partner for the Dialog, but it looks like there's not really a reason for that layer now. I'll get rid of it (or will run into the reason I can't get rid of it).
RoyEJohnson
force-pushed
the
group-partners-by-age
branch
from
02e157f to
b9df3aa
Compare
Remove dialog-context, pass title/setTitle around Remove commented-out stars and count Stop re-shuffling partners every time you view details Use Object.keys instead of Reflect.ownKeys
RoyEJohnson
force-pushed
the
group-partners-by-age
branch
from
b9df3aa to
9e2bd1f
Compare
CORE-608