Code review issues

Remove dialog-context, pass title/setTitle around
Remove commented-out stars and count
Stop re-shuffling partners every time you view details
Use Object.keys instead of Reflect.ownKeys

src/app/pages/partners/partner-details/partner-context.js

@@ -1,11 +1,9 @@
 import buildContext from '~/components/jsx-helpers/build-context';
 import useReviews from '~/models/reviews';
-import useDialogContext from '../results/dialog-context';
 
 // eslint-disable-next-line complexity
-function useContextValue({id: partnerId, model}) {
+function useContextValue({id: partnerId, model, title, setTitle}) {
     const [ratings, postRating] = useReviews(partnerId);
-    const {title, setTitle} = useDialogContext();
 
     if (!ratings) {
         return {};

src/app/pages/partners/partner-details/partner-details.js

@@ -145,9 +145,9 @@ function PartnerDetailsOrInfoRequestForm({model}) {
     );
 }
 
-export default function PartnerDetailsWrapper({detailData: {id, ...model}}) {
+export default function PartnerDetailsWrapper({detailData: {id, ...model}, title, setTitle}) {
     return (
-        <PartnerContextProvider contextValueParameters={{id, model}}>
+        <PartnerContextProvider contextValueParameters={{id, model, title, setTitle}}>
             <PartnerDetailsOrInfoRequestForm model={model} />
         </PartnerContextProvider>
     );

src/app/pages/partners/results/result-grid.tsx

@@ -46,12 +46,6 @@ function ResultCard({entry}: {entry: PartnerEntry}) {
                     <div key={value}>{value}</div>
                 ))}
             </div>
-            {/*
-            <StarsAndCount
-                rating={summary.rating}
-                count={summary.count}
-                showNumber />
-            */}
         </a>
     );
 }

src/app/pages/partners/results/results.tsx

@@ -121,10 +121,13 @@ function filterBy(
 // eslint-disable-next-line complexity
 function useFilteredEntries(entries: PartnerEntry[]) {
     const {books, types, advanced, sort, resultCount} = useSearchContext();
+    const unfilteredResults = React.useMemo(
+        () => shuffle(entries),
+        [entries]
+    );
     const finalResult = React.useMemo(() => {
-        let result = shuffle(entries);
+        let result = filterByBooks(unfilteredResults, books);
 
-        result = filterByBooks(result, books);
         result = filterByType(result, types);
 
         if (advanced.value.length > 0) {
@@ -146,7 +149,7 @@ function useFilteredEntries(entries: PartnerEntry[]) {
         }
 
         return result;
-    }, [entries, advanced, books, types]);
+    }, [unfilteredResults, advanced, books, types]);
 
     resultCount.setValue(finalResult.length);
 
@@ -173,7 +176,7 @@ function useFilteredEntries(entries: PartnerEntry[]) {
 }
 
 function advancedFilterKeys(partnerEntry: PartnerData) {
-    return (Reflect.ownKeys(partnerEntry) as Array<keyof PartnerData>).filter(
+    return (Object.keys(partnerEntry) as Array<keyof PartnerData>).filter(
         (k) => ([false, true] as unknown[]).includes(partnerEntry[k])
     );
 }
@@ -222,7 +225,7 @@ function resultEntry(pd: PartnerData) {
         ratingCount: pd.rating_count,
         partnershipLevel: pd.partnership_level,
         yearsAsPartner: pd.partner_anniversary_date
-            ? differenceInYears(Date.now(), pd.partner_anniversary_date)
+            ? differenceInYears(Date.now(), new Date(pd.partner_anniversary_date))
             : null
     };
 }

src/app/pages/partners/results/selected-partner-dialog.tsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import PartnerDetails from '../partner-details/partner-details';
 import Dialog from '~/components/dialog/dialog';
-import useDialogContext, {DialogContextProvider} from './dialog-context';
 import {useNavigate, useLocation} from 'react-router-dom';
 import type {LinkTexts, PartnerEntry} from './results';
 
@@ -14,13 +13,25 @@ export default function SelectedPartnerDialog({
 }) {
     const [partner, closePartner] = usePartnerFromLocation(entries);
     const detailData = {...partner, ...linkTexts};
+    const [title, setTitle] = React.useState('');
+
+    // Reset between partners
+    React.useEffect(() => setTitle(''), [partner]);
 
     return (
-        <DialogContextProvider contextValueParameters={partner}>
-            <DialogInContext isOpen={Boolean(partner)} onPutAway={closePartner}>
-                {Boolean(partner) && <PartnerDetails detailData={detailData} />}
-            </DialogInContext>
-        </DialogContextProvider>
+        <Dialog
+            title={title}
+            isOpen={Boolean(partner)}
+            onPutAway={closePartner}
+        >
+            {Boolean(partner) && (
+                <PartnerDetails
+                    detailData={detailData}
+                    title={title}
+                    setTitle={setTitle}
+                />
+            )}
+        </Dialog>
     );
 }
 
@@ -41,9 +52,3 @@ function usePartnerFromLocation(
 
     return [partner, closePartner];
 }
-
-function DialogInContext(dialogProps: Parameters<typeof Dialog>[0]) {
-    const {title} = useDialogContext();
-
-    return <Dialog title={title} {...dialogProps} />;
-}