Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS-3063: Adding the needed packages for Kubesan and the kSAN Storage Operator #1701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeff-roche
Copy link

@jeff-roche jeff-roche commented Dec 19, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@jeff-roche: This pull request references COS-3063 which is a valid jira issue.

In response to this:

Additoinal tracker: https://issues.redhat.com/browse/OCPEDGE-1418

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@jeff-roche: This pull request references COS-3063 which is a valid jira issue.

In response to this:

Additional tracker: https://issues.redhat.com/browse/OCPEDGE-1418

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeff-roche
Copy link
Author

cc @brandisher @mike-nguyen @jlebon
We opted for ksan-storage for the extension name since that is the tentative product name.

@jlebon
Copy link
Member

jlebon commented Dec 19, 2024

Looks good, but can you tweak the commit message?

  • Use the imperative mood
  • Add context about what this change does and why
  • Link to the Jira ticket

@mike-nguyen
Copy link
Member

Does this obsolete #1697?

@jeff-roche
Copy link
Author

Does this obsolete #1697?

Yes, I left a comment on #1697 saying it will be closed in favor of this PR

The Kubesan CSI driver requires sanlock and lvm2-lockd for managing
i/o locks on shared, multi-node logical volumes

This work is being completed as part of the following jiras:
- https://issues.redhat.com/browse/OCPEDGE-1418
- https://issues.redhat.com//browse/COS-3063

Signed-off-by: Jeff Roche <[email protected]>
@jeff-roche jeff-roche force-pushed the ksan-storage-extension branch from ad973bf to eac84ef Compare December 19, 2024 16:47
@jeff-roche
Copy link
Author

@jlebon I've updated the commit message to contain the information you requested

@jlebon
Copy link
Member

jlebon commented Dec 19, 2024

Thanks!

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants