COS-3063: Add kubesan host dependencies #1697
Conversation
…n shared, multi-node logical volumes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: copejon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
copejon
changed the title
|
/jira refresh |
|
@copejon: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
copejon
changed the title
|
/jira refresh |
|
@copejon: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@copejon: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| sanlock: | ||
| packages: | ||
| - sanlock | ||
| lvm2-lockd: | ||
| packages: | ||
| - lvm2-lockd |
There was a problem hiding this comment.
Are you sure those shouldn't be in one extension instead? Is there a use case we care about for layering just one without the other?
There was a problem hiding this comment.
It looks like these should be under one extension from what I can infer from the docs; you need lvm2-lockd to enable LVM locking and then a lock manager, sanlockd in this case.
Are there recommendations on how to name the extension? Should we just be calling it ksan (the operator name) or something else?
There was a problem hiding this comment.
We don't have any official naming conventions. I'd prefer kubesan over ksan because it's more explicit.
travier
changed the title
|
@copejon: This pull request references COS-3063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@copejon: This pull request references COS-3063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@travier: This pull request references COS-3063 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
See: