-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved workflow-steps.json to Enum #523
Moved workflow-steps.json to Enum #523
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
============================================
- Coverage 72.11% 72.00% -0.11%
+ Complexity 624 609 -15
============================================
Files 78 78
Lines 3159 3222 +63
Branches 239 247 +8
============================================
+ Hits 2278 2320 +42
- Misses 776 789 +13
- Partials 105 113 +8 ☔ View full report in Codecov by Sentry. |
87b9ec3
to
5ebb4af
Compare
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ToolStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking the suggestions, I like how you did the map.
Should follow up here be to combine the WorkflowResources to this too? |
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
db8292e
to
56a9796
Compare
WorkflowResources is not part of this issue. Can you create a separate issue for the same? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 be0df19e3e3579a018e0d6f0ba423228f0d0491d
# Push it to GitHub
git push --set-upstream origin backport/backport-523-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
* Created enum for workflow steps json Signed-off-by: Owais Kazi <[email protected]> * Added getters for enum and rest of the enums Signed-off-by: Owais Kazi <[email protected]> * Removed workflow-steps.json entries and the file completely Signed-off-by: Owais Kazi <[email protected]> * Fixed tests Signed-off-by: Owais Kazi <[email protected]> * Added entry to CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments and removed the map Signed-off-by: Owais Kazi <[email protected]> * Updated CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit be0df19)
* Created enum for workflow steps json Signed-off-by: Owais Kazi <[email protected]> * Added getters for enum and rest of the enums Signed-off-by: Owais Kazi <[email protected]> * Removed workflow-steps.json entries and the file completely Signed-off-by: Owais Kazi <[email protected]> * Fixed tests Signed-off-by: Owais Kazi <[email protected]> * Added entry to CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments and removed the map Signed-off-by: Owais Kazi <[email protected]> * Updated CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit be0df19) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Moved workflow-steps.json to Enum (#523) * Created enum for workflow steps json * Added getters for enum and rest of the enums * Removed workflow-steps.json entries and the file completely * Fixed tests * Added entry to CHANGELOG.md * Addressed PR comments and removed the map * Updated CHANGELOG.md --------- (cherry picked from commit be0df19) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Moved workflow-steps.json to Enum and removed additional parsing required for the workflow-steps.json. Also, removed the json file.
TODO:1. Fix testsIssues Resolved
Resolves #395
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.