[Backport 2.x] Moved workflow-steps.json to Enum #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Created enum for workflow steps json Signed-off-by: Owais Kazi <[email protected]> * Added getters for enum and rest of the enums Signed-off-by: Owais Kazi <[email protected]> * Removed workflow-steps.json entries and the file completely Signed-off-by: Owais Kazi <[email protected]> * Fixed tests Signed-off-by: Owais Kazi <[email protected]> * Added entry to CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments and removed the map Signed-off-by: Owais Kazi <[email protected]> * Updated CHANGELOG.md Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit be0df19) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Feb 19, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #529 +/- ##
============================================
- Coverage 72.11% 72.00% -0.11%
+ Complexity 624 609 -15
============================================
Files 78 78
Lines 3159 3222 +63
Branches 239 247 +8
============================================
+ Hits 2278 2320 +42
- Misses 776 789 +13
- Partials 105 113 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport be0df19 from #523.