-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fail build when netlify form detected #2512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
…n-nextjs into rs/verify-no-forms
pieh
reviewed
Jun 27, 2024
pieh
reviewed
Jun 27, 2024
Co-authored-by: Michal Piechowiak <[email protected]>
pieh
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Netlify Forms are not supported in v5 and we have currently excluded affected customers from the rollout. This PR will fail the build when a Netlify Form is detected, meaning we can start to migrate customers away from Forms.
The PR simply uses a regex to check for the existence of
data-netlify
within a<form>
tag in the prerendered content.UPDATE: this verification is now passive and only logs a warning so that we can monitor and reach out to customers before beginning the migration
Tests
Integration tests added
Relevant links (GitHub issues, etc.) or a picture of cute animal
Closes FRP-696
BEGIN_COMMIT_OVERRIDE
feat: warn when netlify form detected
END_COMMIT_OVERRIDE