feat: check for netlify forms workaround #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.02%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
orinokai
commented
Jul 2, 2024
| @@ -172,7 +172,7 @@ export const copyPrerenderedContent = async (ctx: PluginContext): Promise<void> | |||
|
|
|||
| // Netlify Forms are not support and require a workaround | |||
| if (value.kind === 'PAGE' || value.kind === 'APP_PAGE') { | |||
| verifyNoNetlifyForms(ctx, value.html) | |||
| verifyNetlifyForms(ctx, value.html) | |||
There was a problem hiding this comment.
I made these verifications all positive because it was getting confusing knowing when to warn
pieh
reviewed
Jul 2, 2024
pieh
reviewed
Jul 2, 2024
orinokai
force-pushed
the
rs/verify-forms-workaround
branch
from
1757ae2 to
7b13326
Compare
pieh
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A previous PR introduced a warning for customers using Netlify Forms. This PR adds a check to skip the warning if the forms workaround is detected in use.
Tests
Integration tests added
Relevant links (GitHub issues, etc.) or a picture of cute animal
Closes FRP-696