(refactor) Tweak calcMonthsOnART helper logic

[denniskigen]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

Tweaks the logic of the calcMonthsOnART expression helper function to use dayjs for more accurate month calculation. Presently, it only calculates months if at least 30 days have passed since the ART start date. It does so by calculating the difference in days between today and the ART start date, and then dividing by 30.

This PR changes the logic to use dayjs to calculate the difference in months between today and the ART start date. The motivation for this change is to fix a failing test on the main branch that arose from the previous logic.

Screenshots

Failing test on main

Failing test in CI

Related Issue

Other

Test plan

@samuelmale could you advise on an appropriate test plan for this change?

[github-actions]

Size Change: -54 B (0%)

Total Size: 1.25 MB

ℹ️ View Unchanged

Filename	Size	Change
dist/151.js	379 kB	0 B
dist/225.js	2.57 kB	0 B
dist/254.js	88.7 kB	0 B
dist/277.js	1.85 kB	0 B
dist/300.js	642 B	0 B
dist/335.js	968 B	0 B
dist/353.js	3.02 kB	0 B
dist/41.js	3.37 kB	0 B
dist/539.js	263 kB	-28 B (-0.01%)
dist/540.js	2.63 kB	0 B
dist/55.js	758 B	0 B
dist/585.js	112 kB	0 B
dist/635.js	14.4 kB	0 B
dist/690.js	11.5 kB	0 B
dist/70.js	483 B	0 B
dist/979.js	6.87 kB	0 B
dist/99.js	691 B	0 B
dist/993.js	3.09 kB	0 B
dist/main.js	355 kB	-26 B (-0.01%)
dist/openmrs-esm-form-engine-lib.js	3.8 kB	0 B

_{compressed-size-action}