(feat) O3-3911 Display all items on ui-select-extended

[ODORA0]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

• Updated shouldFilterItem to always return true, ensuring all items are displayed when the caret is clicked.
• Adjusted tests to validate that all items remain visible even after typing input.

Screenshots

Screen.Recording.2024-12-04.at.22.07.33.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-3911

Other

[samuelmale]

Can you update your branch to pick up the fix for the failing CI build?

[samuelmale]

@ODORA0 is it possible to fix the issue without getting rid the filter?

[ODORA0]

@samuelmale The filtering restricts options because the shouldFilterItem function dynamically excludes items that don’t match the current inputValue. If the logic doesn’t explicitly account for an empty inputValue (e.g. when the caret is clicked), only the currently selected item or no items may be displayed, as the filter prevents non-matching items from appearing.

[denniskigen]

Thanks, @ODORA0. How different is this than getting rid of the prop altogether? AFAICT, the filtering behaviour of the ComboBox input where only the matching item is listed when the dropdown is clicked after selecting an item is by design. See the underlying useComboBox hook implementation for the Downshift library here.

I think it's preferable to just remove the prop altogether until the underlying behavior changes upstream from Carbon.

[ODORA0]

@denniskigen I agree, change made

[samuelmale]

Ping @denniskigen

[denniskigen]

Good to go for me, @samuelmale.

[pirupius]

Thanks @ODORA0