fix: 3782 - more relevant check and matomo message #3787

monsieurtanuki · 2023-03-19T14:02:26Z

Impacted files:

add_basic_details_page.dart: unrelated typo fix
analytics_helper.dart: added 2 events for matomo; unrelated typo fix
edit_product_page.dart: unrelated typo fix
smooth_barcode_scanner_mlkit.dart: added an isStarting check; now sends matomo instead of red snackbar; simplified

What

The red snackbars that we displayed are now replaced by matomo messages.
In addition to that, we're now more careful about when to send an alert. More specifically, we use an additional controller check before trying to restart the camera/scanner

Fixes bug(s)

Fixes: Error after leaving product page and upload page #3782

Part of

Upgrade the barcode scan to flutter 3.7 #3712

Impacted files: * `add_basic_details_page.dart`: unrelated typo fix * `analytics_helper.dart`: added 2 events for matomo; unrelated typo fix * `edit_product_page.dart`: unrelated typo fix * `smooth_barcode_scanner_mlkit.dart`: added an `isStarting` check; now sends matomo instead of red snackbar; simplified

codecov-commenter · 2023-03-19T14:06:59Z

Codecov Report

Merging #3787 (eacc67e) into develop (805ca0d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3787   +/-   ##
========================================
  Coverage    10.78%   10.78%           
========================================
  Files          269      269           
  Lines        13403    13396    -7     
========================================
  Hits          1445     1445           
+ Misses       11958    11951    -7

Impacted Files	Coverage Δ
...kages/smooth_app/lib/helpers/analytics_helper.dart	`0.00% <ø> (ø)`
..._app/lib/pages/product/add_basic_details_page.dart	`0.00% <ø> (ø)`
...mooth_app/lib/pages/product/edit_product_page.dart	`0.45% <0.00%> (ø)`
...p/lib/pages/scan/smooth_barcode_scanner_mlkit.dart	`0.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

teolemon

Sound good

monsieurtanuki · 2023-03-20T13:29:59Z

Thank you @teolemon for the review!

monsieurtanuki requested a review from a team as a code owner March 19, 2023 14:02

monsieurtanuki requested a review from M123-dev March 19, 2023 14:02

github-actions bot assigned monsieurtanuki Mar 19, 2023

github-actions bot added 📈 Analytics We use Sentry and Matomo, with an opt-in system 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Mar 19, 2023

monsieurtanuki mentioned this pull request Mar 20, 2023

Upgrade the barcode scan to flutter 3.7 #3712

Closed

teolemon approved these changes Mar 20, 2023

View reviewed changes

monsieurtanuki merged commit 0bf2794 into openfoodfacts:develop Mar 20, 2023

github-actions bot mentioned this pull request Mar 20, 2023

chore(develop): release 4.7.0 #3778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 3782 - more relevant check and matomo message #3787

fix: 3782 - more relevant check and matomo message #3787

monsieurtanuki commented Mar 19, 2023

codecov-commenter commented Mar 19, 2023

teolemon left a comment

monsieurtanuki commented Mar 20, 2023

fix: 3782 - more relevant check and matomo message #3787

fix: 3782 - more relevant check and matomo message #3787

Conversation

monsieurtanuki commented Mar 19, 2023

What

Fixes bug(s)

Part of

codecov-commenter commented Mar 19, 2023

Codecov Report

teolemon left a comment

Choose a reason for hiding this comment

monsieurtanuki commented Mar 20, 2023