-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: use fixed position for ProductTour Checkpoints's #2863
Conversation
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2863 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4240 4240
Branches 1029 1029
=======================================
Hits 3936 3936
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I also checked the functionality of the ProductTour component in MFE Learning.
🎉 This PR is included in version 21.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixes a bug with
ProductTour
's positioning.Screen.Recording.2023-11-27.at.11.21.58.mov
Deploy Preview
https://deploy-preview-2863--paragon-openedx.netlify.app/components/producttour/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist