Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alpha] Problem with ProductTour button, after calculations CSS variables #2800

Closed
PKulkoRaccoonGang opened this issue Nov 10, 2023 · 3 comments · Fixed by #2863
Closed

[alpha] Problem with ProductTour button, after calculations CSS variables #2800

PKulkoRaccoonGang opened this issue Nov 10, 2023 · 3 comments · Fixed by #2863
Assignees
@viktorrusakov
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

In the ProductTour component when you click the Open a product tour button before performing calculations of CSS variables on the page, the button does not work.

Screen.Recording.2023-11-10.at.14.32.21.mov
@PKulkoRaccoonGang PKulkoRaccoonGang added bug Report of or fix for something that isn't working as intended raccoon-gang labels Nov 10, 2023
@adamstankiewicz
Copy link
Member

Let's sanity check that this issue does NOT happen for consuming MFEs.

@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Nov 20, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Nov 23, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Nov 23, 2023
@viktorrusakov viktorrusakov linked a pull request Nov 27, 2023 that will close this issue
[BD-46] fix: use fixed position for ProductTour Checkpoints's #2863
Merged
10 tasks
@viktorrusakov
Copy link
Contributor

The root cause is not CSS variables calculations but incorrect usage of underlying popper element, it is also reproduced in master branch as can be seen in the linked PR.

@viktorrusakov viktorrusakov moved this from In progress to In review in Paragon Working Group Nov 27, 2023
@monteri
Copy link
Contributor

monteri commented Dec 7, 2023

#2863

@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktorrusakov viktorrusakov

Labels
bug Report of or fix for something that isn't working as intended raccoon-gang
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BD-46] fix: use fixed position for ProductTour Checkpoints's openedx/paragon
4 participants
@adamstankiewicz @monteri @viktorrusakov @PKulkoRaccoonGang