Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable account deletion #817

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Allow disable account deletion #817

merged 6 commits into from
Aug 28, 2023

Conversation

JonasBM
Copy link
Contributor

@JonasBM JonasBM commented Jul 5, 2023

Referenced issue: There is no way to disable account deletion in the Account MFE #189

Add environment variable ENABLE_ACCOUNT_DELETION, to allow the disable of account deletion.
To disable account deletion set ENABLE_ACCOUNT_DELETION="false", otherwise it will default to true.

Updated JumpNav test to include the no render of account deletion components.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 5, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 5, 2023

Thanks for the pull request, @JonasBM! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@JonasBM
Copy link
Contributor Author

JonasBM commented Jul 5, 2023

About the test, i just updated the existing one. If necessary i can create two other tests just for this feature.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
@JonasBM
Copy link
Contributor Author

JonasBM commented Jul 7, 2023

Fixed linting errors.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 7, 2023
@mphilbrick211
Copy link

Hi @JonasBM! Is this all set for review?

@JonasBM
Copy link
Contributor Author

JonasBM commented Jul 10, 2023

Hi, @mphilbrick211! Yes.
I think that to complete solve the issue there is a back-end change that should be done. But for that I will post in the forum and discuss before any change.
For the front-end (this change) is all good for a review.

@mphilbrick211
Copy link

Hi @openedx/fed-bom! Could someone please review/merge this for us? Thanks!

@JonasBM
Copy link
Contributor Author

JonasBM commented Jul 12, 2023

About this solution, i have some questions that i post in the forum, please give a read, especially if this PR is accepted.
Solving the issue for disable account deletion in the Account MFE

@abdullahwaheed abdullahwaheed self-requested a review July 14, 2023 05:34
@mphilbrick211
Copy link

Apologies, @abdullahwaheed - I see you already plan to review - thanks!

@mariajgrimaldi
Copy link
Member

Hi there, @abdullahwaheed. What do we need to merge this PR?

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (7c0ea75) 46.54% compared to head (03dd90e) 46.54%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files         122      122           
  Lines        2544     2548    +4     
  Branches      665      669    +4     
=======================================
+ Hits         1184     1186    +2     
- Misses       1284     1286    +2     
  Partials       76       76           
Files Changed Coverage Δ
src/account-settings/AccountSettingsPage.jsx 1.40% <0.00%> (-0.02%) ⬇️
src/index.jsx 0.00% <ø> (ø)
src/account-settings/JumpNav.jsx 91.66% <100.00%> (+1.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasBM
Copy link
Contributor Author

JonasBM commented Aug 19, 2023

Fixed a conflict in the merge.

@mphilbrick211
Copy link

Hi @abdullahwaheed! Would you be able to enable tests again for this PR?

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 21, 2023
@abdullahwaheed
Copy link
Contributor

@JonasBM could you please resolve conflicts so we can merge this PR

@abdullahwaheed abdullahwaheed added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 23, 2023
@JonasBM
Copy link
Contributor Author

JonasBM commented Aug 23, 2023

@JonasBM could you please resolve conflicts so we can merge this PR

Done.

@abdullahwaheed abdullahwaheed removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 23, 2023
@abdullahwaheed
Copy link
Contributor

@JonasBM just another suggestion. Could you update Readme accordingly so we have a proper documentation of this flag and its functionality

@JonasBM
Copy link
Contributor Author

JonasBM commented Aug 25, 2023

@JonasBM just another suggestion. Could you update Readme accordingly so we have a proper documentation of this flag and its functionality

Done!
Let me know if anything is wrong.

Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@abdullahwaheed abdullahwaheed merged commit 49bc817 into openedx:master Aug 28, 2023
@openedx-webhooks
Copy link

@JonasBM 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

snglth pushed a commit to Abstract-Tech/community-theme-account that referenced this pull request Jan 9, 2024
* feat: allow disable account deletion

* test: add disable account deletion to test case

* style: fix lint errors

* docs: Add ENABLE_ACCOUNT_DELETION to README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants