Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to disable account deletion in the Account MFE #189

Closed
regisb opened this issue Jun 27, 2022 · 15 comments
Closed

There is no way to disable account deletion in the Account MFE #189

regisb opened this issue Jun 27, 2022 · 15 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended
Milestone

Comments

@regisb
Copy link
Contributor

regisb commented Jun 27, 2022

In the legacy account view from edx-platform, it was possible to remove the possibility of account deletion by defining the ENABLE_ACCOUNT_DELETION feature flag:

Source:
https://edx.readthedocs.io/projects/edx-platform-technical/en/latest/featuretoggles.html#featuretoggle-FEATURES%5B'ENABLE_ACCOUNT_DELETION'%5D
https://github.com/openedx/edx-platform/blob/20de3c71b4951472947917d2388e8412f53f6bcc/openedx/core/djangoapps/user_api/accounts/settings_views.py#L142

Now, in the frontend-app-account MFE, this feature flag seems to be ignored: https://github.com/openedx/edx-platform/blob/20de3c71b4951472947917d2388e8412f53f6bcc/openedx/core/djangoapps/user_api/accounts/settings_views.py#L74

As a consequence, it is no longer possible to disable account deletion.

This issue was detected following this conversation: https://discuss.openedx.org/t/some-feature-toggles-dont-work/7635

@regisb regisb added affects:nutmeg bug Report of or fix for something that isn't working as intended labels Jun 27, 2022
@BbrSofiane BbrSofiane added this to the Nutmeg.2 milestone Jul 3, 2022
@BbrSofiane BbrSofiane modified the milestones: Nutmeg.2, Nutmeg.3 Aug 13, 2022
@nikoi4
Copy link

nikoi4 commented Aug 16, 2022

I am probably missing a lot of context in here, but based on the origins of the flag ENABLE_ACCOUNT_DELETION in PR and in order to be GDPR compliant on the 'Right to be forgotten' I do not believe this is a bug. Missing the possibility of disabling account deletion looks like a intentional decision? Again I do not have full context.

@arbrandes arbrandes removed this from the Nutmeg.3 milestone Dec 6, 2022
@regisb
Copy link
Contributor Author

regisb commented Jan 3, 2023

  1. If account deletion is mandatory, then the feature flag should be removed.
  2. If platform administrators are able to disable account deletion, then this feature flag should be respected.

I think that we should go with option 2. For instance, account deletion could be disabled outside of Europe or in private Open edX instances.

@potap75
Copy link

potap75 commented Mar 1, 2023

You need to consult with the Legal about this issue. That's because many jurisdictions around the world have laws similar to GDPR which stipulates that a user must be able to delete the account at any moment.

@regisb
Copy link
Contributor Author

regisb commented Mar 2, 2023

There are some cases where user account deletion should be deactivated. For instance when running a private instance of Open edX inside a company. In such cases GDPR does not apply.

The default should be to allow account deletion (according to GDPR) but platform administrators should be able to deactivate this feature (IMHO).

@ghost
Copy link

ghost commented Jun 11, 2023

Hello

I'm keen on picking up the above issue, any objections? Thank you

@ghost
Copy link

ghost commented Jun 24, 2023

Apologies team, I no longer have the bandwidth to contribute!

@JonasBM
Copy link

JonasBM commented Jun 28, 2023

Hi!
Since this was dropped by alfstooqi, maybe i can have a go at it if no one is working on it.
Let me know if it is a problem.

@JonasBM
Copy link

JonasBM commented Jul 5, 2023

I have take some time to learn more about the project, and i have some questions about the issue.
Will create a environment variable (ENABLE_ACCOUNT_DELETION) on the front end and hide the component be enough?
Is spectated to show any message, letting the user know that his account cannot be delete, and if he want, he need to call the support or something like that?

@JonasBM
Copy link

JonasBM commented Jul 12, 2023

I have some questions about the solution for this issue. Please read the post in the forum.

@mariajgrimaldi mariajgrimaldi moved this from Backlog to In progress in Build-Test-Release Working Group Aug 7, 2023
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Aug 7, 2023

Hi @JonasBM, thanks for your contribution! I see you opened a PR in account MFE that was already approved. Let us know when it's merged! Also, there was also a fix in the backend, can you link the PR for that one as well? Thanks!

@JonasBM
Copy link

JonasBM commented Aug 15, 2023

Hi @mariajgrimaldi Someone asked to contribute to the backend issue, but looks like he is not gonna fix it. I will try to make a PR to fix the backend this week, so maybe we can close this issue.

@JonasBM
Copy link

JonasBM commented Aug 28, 2023

@mariajgrimaldi the PR was merged on the MFE. Regarding the backend part, @kiran1415 seems to be taking care of it.

@mariajgrimaldi
Copy link
Member

Great! Thank you @JonasBM 🥳

@mariajgrimaldi mariajgrimaldi modified the milestones: Palm.3, Quince.1 Oct 16, 2023
@cmltaWt0 cmltaWt0 modified the milestones: Quince.1, Quince.2 Jan 8, 2024
@mariajgrimaldi mariajgrimaldi modified the milestones: Quince.2, Quince.3 Feb 12, 2024
@mariajgrimaldi mariajgrimaldi modified the milestones: Quince.3, Redwood.1 Apr 26, 2024
@DonatoBD
Copy link

Hi, this could be marked as complete because it depends on these two PRs:

I already tested it and it works perfectly 😄

Pdt: this PR is already in quince so if we backport this one it could also be available in quince.master

I remain attentive to your recommendations

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Apr 30, 2024

Thank you so much for helping us out, @DonatoBD! I'll close this now. If any other issue arises, a new ticket should be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Development

No branches or pull requests