Introduce rbac controller to handle RoleBindings

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-580

Description

The PR introduce a new controller under odh-controller that handles the RoleBindings

How Has This Been Tested?

Created new test cases on the notebook_controller_test.go for RoleBinding creation, delete and update.

The video bellow demonstrates three different scenarios

• Create a notebook on a DSP without the existence on a pipeline server, in that case should not create any Rolebinding because the specific Role
• Setup a pipeline server, once is done then create a new notebook, on this new notebook we shouuld see the rolebinding named elyra-pipeline-<notebook-name>
• Last, delete the notebook, and eventually delete the rolebinding as well.

https://drive.google.com/file/d/1uJJumxBiZukyVNakQ0uULZ68syKpq_3o/view?usp=sharing

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[atheo89]

/retest-required

[atheo89]

/retest-required

[harshad16]

Thank you for the great changes.
One additional request, we would like to keep this feature behind devflag and default keep it false, in future, once the bits are cleaned from dashboard , we would make it true, in this way this feature doesn't need to be stalled on dev side.

[atheo89]

The GHA tests had a great catch on the new changes! So since the configMap was false the operator didn't create any rolebinding and that why had the failure https://github.com/opendatahub-io/kubeflow/actions/runs/11611201427/job/32332040147?pr=434#step:4:540

Need to update the tests, in case that found SET_PIPELINE_RBAC=false to don't run the tests

[jiridanek]

/lgtm overall, if I understand this correctly it just moves the rolebinding creation that dashboard used to do into our controller, but I'd want harshad to check it too ;p

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[atheo89]

/retest-required

[atheo89]

/test odh-notebook-controller-unit

[atheo89]

/test odh-notebook-controller-unit

[jiridanek]

/lgtm

[harshad16]

lgtm

i have tested the os.getenv, seems to be working as expected.
perhaps, we should take a closer look.

anyhow have few more comments

[jiridanek]

/lgtm
looked it over and gha is passing

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atheo89]

Thank you all for you time to review this and make it better!
I move on to merge this in order to start the release.

/override ci/prow/odh-notebook-controller-e2e

[openshift-ci]

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/odh-notebook-controller-e2e

In response to this:

Thank you all for you time to review this and make it better!
I move on to merge this in order to start the release.

/override ci/prow/odh-notebook-controller-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.