Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have a helper function for devFlags, to be used everywhere we're checking a bool env var flag #440

Open
jiridanek opened this issue Nov 6, 2024 · 0 comments

Comments

@jiridanek
Copy link
Member

          We should have a helper function for this, to be used everywhere we're checking a bool env var flag. I'll open a ticket from this comment to remember.

One possibility would be to use https://pkg.go.dev/strconv#ParseBool there; and another possibility would be to accept "true" as true and any other string as "false"; not sure if we should have defaults for when env variable is not present (current code takes that as false, if I am looking correctly).

Originally posted by @jiridanek in #434 (comment)

@jiridanek jiridanek changed the title We should have a helper function for devFlags, to be used everywhere we're checking a bool env var flag. I'll open a ticket from this comment to remember. We should have a helper function for devFlags, to be used everywhere we're checking a bool env var flag Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant