You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should have a helper function for this, to be used everywhere we're checking a bool env var flag. I'll open a ticket from this comment to remember.
One possibility would be to use https://pkg.go.dev/strconv#ParseBool there; and another possibility would be to accept "true" as true and any other string as "false"; not sure if we should have defaults for when env variable is not present (current code takes that as false, if I am looking correctly).
jiridanek
changed the title
We should have a helper function for devFlags, to be used everywhere we're checking a bool env var flag. I'll open a ticket from this comment to remember.
We should have a helper function for devFlags, to be used everywhere we're checking a bool env var flag
Dec 1, 2024
One possibility would be to use https://pkg.go.dev/strconv#ParseBool there; and another possibility would be to accept "true" as true and any other string as "false"; not sure if we should have defaults for when env variable is not present (current code takes that as false, if I am looking correctly).
Originally posted by @jiridanek in #434 (comment)
The text was updated successfully, but these errors were encountered: