Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux process cgroup attribute #1364

Merged
merged 16 commits into from
Nov 25, 2024

Conversation

rogercoll
Copy link
Contributor

Fixes # #1357

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@rogercoll rogercoll requested review from a team August 23, 2024 18:39
model/registry/linux.yaml Outdated Show resolved Hide resolved
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Sep 15, 2024
model/registry/linux.yaml Outdated Show resolved Hide resolved
model/registry/linux.yaml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 8, 2024
@rogercoll rogercoll requested review from a team as code owners October 9, 2024 15:42
@github-actions github-actions bot removed the Stale label Oct 10, 2024
@rogercoll rogercoll requested a review from a team as a code owner October 11, 2024 12:47
@rogercoll
Copy link
Contributor Author

@open-telemetry/semconv-system-approvers Could you take a look at this PR when you have a moment? Thanks!

model/linux/registry.yaml Outdated Show resolved Hide resolved
@jsuereth
Copy link
Contributor

Would you mind taking a look at the changelog error and fixing that?

@joaopgrassi
Copy link
Member

Would you mind taking a look at the changelog error and fixing that?

This was a problem on main, updating the PR has now fixed it 👍

model/linux/registry.yaml Outdated Show resolved Hide resolved
model/linux/registry.yaml Outdated Show resolved Hide resolved
@mmanciop
Copy link

I love the idea of having cgroup identifiers at hand: in Kubernetes that means that the k8s.pod.ui, which is part of the cgroup identifier, is just one OTTL rule away :-)

@lmolkova lmolkova enabled auto-merge (squash) November 25, 2024 17:36
@lmolkova lmolkova merged commit b75c8c2 into open-telemetry:main Nov 25, 2024
13 of 14 checks passed
@rogercoll rogercoll deleted the add_process_cgroup branch November 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants