Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should OS-specific metrics be in system.{os} or {os} namespace #1255

Closed
lmolkova opened this issue Jul 15, 2024 · 2 comments
Closed

Should OS-specific metrics be in system.{os} or {os} namespace #1255

lmolkova opened this issue Jul 15, 2024 · 2 comments

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jul 15, 2024

currently both of these namespaces are used in this PR:

  • linux.*
  • and system.linux.*

should we rename system.linux.* to linux.*?

that would seem to align with our decision to move process.runtime.jvm.* to jvm.*

Originally posted by @trask in #1078 (comment)

@lmolkova lmolkova changed the title System metrics: should OS-specific metrics be in system.{os} or {os} namespace Should OS-specific metrics be in system.{os} or {os} namespace Jul 15, 2024
@lmolkova lmolkova added the enhancement New feature or request label Jul 15, 2024
@mx-psi
Copy link
Member

mx-psi commented Nov 14, 2024

@lmolkova Is this a duplicate of #1403?

@lmolkova
Copy link
Contributor Author

Based on the recent discussion - #1364 (comment), I believe we're leaning towards system.{os}. I'm going to close it since it should be addressed in #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants