Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spec 1.26.0 and semconv 1.22.0 at the SAME time #3388

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 16, 2023

Preview:

/cc @svrnm

@chalin chalin requested review from a team October 16, 2023 17:35
@chalin
Copy link
Contributor Author

chalin commented Oct 16, 2023

An OpAMP semconv link is invalid, and is breaking the build (because we have build-time link checking for cross-spec links -- something to be revisited soon). So, atm, we're waiting on:

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll approve this now so you can merge it when ever the dependencies are fixed

@tigrannajaryan
Copy link
Member

So, atm, we're waiting on:

Merged.

@chalin chalin force-pushed the chalin-im-update-spec+semconv-20231016 branch from 011071c to 0df450f Compare October 16, 2023 19:44
@chalin
Copy link
Contributor Author

chalin commented Oct 16, 2023

So that we can get schema 1.22.0 out, I've disabled some link checks etc. I'll reenable them via:

@chalin chalin merged commit da582e5 into open-telemetry:main Oct 16, 2023
12 checks passed
@chalin chalin deleted the chalin-im-update-spec+semconv-20231016 branch October 16, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants