Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-specification version to 1.28.0 #3658

Merged

Conversation

opentelemetrybot
Copy link
Collaborator

Update opentelemetry-specification version to 1.28.0.

See https://github.com/open-telemetry/opentelemetry-specification/releases/tag/v1.28.0.

@opentelemetrybot opentelemetrybot requested review from a team December 7, 2023 17:15
@svrnm
Copy link
Member

svrnm commented Dec 7, 2023

WARNINGs or ERRORs found in build log:
ERROR [en] REF_NOT_FOUND: Ref "/docs/specs/semconv/general/attribute-naming.md": "/home/runner/work/opentelemetry.io/opentelemetry.io/tmp/otel/specification/common/attribute-naming.md:6:83": page not found
ERROR [en] REF_NOT_FOUND: Ref "/docs/specs/semconv/general/attribute-requirement-level.md": "/home/runner/work/opentelemetry.io/opentelemetry.io/tmp/otel/specification/common/attribute-requirement-level.md:6:94": page not found
ERROR [en] REF_NOT_FOUND: Ref "/docs/specs/semconv/general/attribute-naming.md": "/home/runner/work/opentelemetry.io/opentelemetry.io/tmp/otel/specification/common/_index.md:44:24": page not found
ERROR [en] REF_NOT_FOUND: Ref "/docs/specs/semconv/general/attribute-requirement-level.md": "/home/runner/work/opentelemetry.io/opentelemetry.io/tmp/otel/specification/common/_index.md:46:25": page not found
Error: error building site: logged 4 error(s)

@svrnm
Copy link
Member

svrnm commented Dec 8, 2023

@open-telemetry/specs-approvers , @open-telemetry/specs-semconv-approvers please take a look here. The latest release of the spec is referencing elements of the semantic conventions which have not yet been released, breaking links in this commit:

To be more specific: Attribute Naming & Attribute Requirement Level files were moved to semconv, but that part is not released with semconv

Are there any plans to provide a new release of semconv as well?

@svrnm svrnm added the blocked label Dec 8, 2023
@chalin
Copy link
Contributor

chalin commented Dec 8, 2023

We might have to wait and update both the OTel spec and Semconv at the same time, as we have done at least once in the past (as you might recall):

@opentelemetrybot opentelemetrybot requested a review from a team December 16, 2023 15:17
@cartermp cartermp removed the blocked label Dec 16, 2023
@cartermp cartermp merged commit 1d60577 into main Dec 16, 2023
16 checks passed
@cartermp cartermp deleted the opentelemetrybot/auto-update-opentelemetry-specification-1.28.0 branch December 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants