Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for making new capability proposals #207

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,25 @@ If any changes are made to Protobuf message definitions in the specification.md
sure to update also the `*.proto` files in the [proto](proto) directory. Run `make gen-proto`
to run the Protobuf compiler and verify the `*.proto` files.

## Proposal Requirements

Proposals to add new capabilities to OpAMP specification must be accompanied by working
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved
prototypes in [opamp-go](https://github.com/open-telemetry/opamp-go), demonstrating
the capability. The prototype can be a PR against opamp-go or can be on your own fork
of opamp-go.
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved

To make a proposal create a PR in this repo that modifies the specification markdown
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved
and the Protobuf files and include a link to the prototype in the description. We
advise to attend the OpAMP SIG meeting and discuss your proposal before you spend
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved
effort on it to make sure the proposal is aligned with SIG's vision.
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved

All new capabilities must be added in
[Development](https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/0232-maturity-of-otel.md#development)
maturity level initially. Make sure to add `[Development]` status label in the
tigrannajaryan marked this conversation as resolved.
Show resolved Hide resolved
specification markdown and as a prefix of the added proto field or message.

## Contributors

Approvers ([@open-telemetry/opamp-spec-approvers](https://github.com/orgs/open-telemetry/teams/opamp-spec-approvers)):

- [Andy Keller](https://github.com/andykellr), observIQ
Expand Down