-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guidelines for making new capability proposals #207
Merged
tigrannajaryan
merged 3 commits into
open-telemetry:main
from
tigrannajaryan:tigran/contributing
Nov 27, 2024
Merged
Add guidelines for making new capability proposals #207
tigrannajaryan
merged 3 commits into
open-telemetry:main
from
tigrannajaryan:tigran/contributing
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with OpAMP approvers/maintainers this adds the requirement to have working prototypes for specification proposals.
tigrannajaryan
requested review from
andykellr,
evan-bradley and
srikanthccv
November 27, 2024 17:31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, most just wording suggestions.
evan-bradley
approved these changes
Nov 27, 2024
andykellr
reviewed
Nov 27, 2024
andykellr
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion, but otherwise LGTM. Thank you for writing this up.
srikanthccv
approved these changes
Nov 27, 2024
Co-authored-by: Andy Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with OpAMP approvers/maintainers this adds the requirement to have working prototypes for specification proposals.