Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloading state and download_details to PackageStatus #206

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Add downloading state and download_details to PackageStatus #206

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f67ce33
Add downloading state and metadata to packagestatus
michel-laterman Oct 16, 2024
89133c6
mark metadata feature in development stage
michel-laterman Oct 16, 2024
c037c2e
Review feedback; replaced generic map with a concrete details impleme…
michel-laterman Oct 22, 2024
3d03bdd
Review feedback, add new attributes to specification.md
michel-laterman Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion proto/opamp.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,11 @@ message PackageStatus {

// Error message if the status is erroneous.
string error_message = 7;

// Optional details that may be of interest to a user.
// For example the download rate, percent downloaded, or a message.
// Status: [Development]
map<string, string> metadata = 8;
michel-laterman marked this conversation as resolved.
Show resolved Hide resolved
}

// The status of this package.
Expand All @@ -814,7 +819,7 @@ enum PackageStatusEnum {
// Installation of this package has not yet started.
PackageStatusEnum_InstallPending = 1;

// Agent is currently downloading and installing the package.
// Agent is currently installing the package.
// server_offered_hash field MUST be set to indicate the version that the
// Agent is installing. The error_message field MUST NOT be set.
PackageStatusEnum_Installing = 2;
Expand All @@ -824,6 +829,11 @@ enum PackageStatusEnum {
// tried to install. The error_message may also contain more details about
// the failure.
PackageStatusEnum_InstallFailed = 3;

// Agent is currently downloading the package.
// server_offered_hash field MUST be set to indicate the version that the
// Agent is installing. The error_message field MUST NOT be set.
PackageStatusEnum_Downloading = 4;
michel-laterman marked this conversation as resolved.
Show resolved Hide resolved
}

// Properties related to identification of the Agent, which can be overridden
Expand Down