Add downloading state and download_details to PackageStatus #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
previously requested changes
Oct 22, 2024
michel-laterman
changed the title
andykellr
reviewed
Oct 23, 2024
tigrannajaryan
approved these changes
Oct 23, 2024
andykellr
requested changes
Oct 23, 2024
andykellr
approved these changes
Oct 23, 2024
|
@michel-laterman I think this is good to go. It is still shows as a "Draft", but I assume you are done and we can merge? |
|
Yes, we can merge at-will. However I'm unable to run |
Github actions verified it, we are good: https://github.com/open-telemetry/opamp-spec/actions/runs/11483570522/job/31960049021?pr=206 |
|
Thanks @michel-laterman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate
DownloadingPackageStatusEnumso an agent can use a distinguish between downloading and installing a new package.Add a
download_detailsattribute that may optionally be used with the newDownloadingstatus to give a user additional details about the package download: download rate, and percentage download.