-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: attempts with connection improvements #118
feat: attempts with connection improvements #118
Conversation
fa3ef6c
to
ae80e4b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 94.25% 94.00% -0.25%
==========================================
Files 14 14
Lines 731 734 +3
==========================================
+ Hits 689 690 +1
- Misses 42 44 +2 ☔ View full report in Codecov by Sentry. |
76004bc
to
abdb4c9
Compare
blocked by open-feature/flagd#1478 and open-feature/flagd-testbed#172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aepfli let me know, when the blocker is resolved and it is good to merge
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/config.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
abdb4c9
to
86dd9fd
Compare
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
5140a2c
to
fe1df5d
Compare
@aepfli just to make sure, is it ready to merge now? 😅 |
Yes I think it is ready. The tests are also more stable ;) |
Based on open-feature/flagd#1472 we're improving our reconnection logic.
We're using GRPC, and GRPC has already offers a reconnection with a backoff.
Within this PR:
Wait-for-ready
to wait for our stream to have a connection again