Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagd): add custom cert path #131

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Dec 27, 2024

based on #118

closes: #54

@aepfli aepfli force-pushed the feat/add-custom-cert-path branch from 3a618cf to e19d504 Compare December 27, 2024 10:57
@aepfli aepfli changed the title Feat/add custom cert path feat(flagd): add custom cert path Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (f6431e6) to head (438413a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   94.27%   94.10%   -0.18%     
==========================================
  Files          14       14              
  Lines         734      746      +12     
==========================================
+ Hits          692      702      +10     
- Misses         42       44       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aepfli aepfli force-pushed the feat/add-custom-cert-path branch 4 times, most recently from 47fe380 to 5a3b0f2 Compare December 27, 2024 12:18
@aepfli aepfli marked this pull request as ready for review December 27, 2024 12:18
@aepfli aepfli requested a review from a team as a code owner December 27, 2024 12:18
@aepfli aepfli force-pushed the feat/add-custom-cert-path branch from 5a3b0f2 to 8d5234a Compare December 27, 2024 12:20
@aepfli aepfli force-pushed the feat/add-custom-cert-path branch from 8d5234a to e07ce8d Compare December 27, 2024 12:21
Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one question

@gruebel gruebel merged commit f50351a into open-feature:main Dec 27, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flagd-RPC] TLS custom cert support
2 participants