Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): from grace attempts to grace period, plus connection info #1478

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Dec 18, 2024

updating specification based on findings in #1472

@aepfli aepfli requested a review from a team as a code owner December 18, 2024 07:27
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 2984bee
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6763fa9fba08330008411980

@aepfli aepfli force-pushed the feat/grace_attempts_to_grace_period branch from 0e3ccb1 to 8370bfb Compare December 18, 2024 07:40
@aepfli
Copy link
Member Author

aepfli commented Dec 18, 2024

@toddbaert @warber - first time writing spec, please review, guidance much appreciated

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks!

@toddbaert toddbaert requested a review from beeme1mr December 18, 2024 21:24
docs/reference/specifications/providers.md Outdated Show resolved Hide resolved
@toddbaert toddbaert merged commit 35d286a into open-feature:main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants