Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review requests and actionable comments #418

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
2dd8988
Add 'completed_at' column to 'comments' table for keeping track of ac…
Jan 10, 2013
2677715
Add support to the barkeep server for resolving comments.
Jan 15, 2013
19c2df3
Add a 'Resolve' button to comments.
Jan 15, 2013
a427b28
Style the 'Resolve' button more like the 'Approve Commit' button.
Jan 15, 2013
f905111
Do not display the 'Resolve' button for comments and replies by the c…
Jan 15, 2013
77265b1
Allow any user to resolve and unresolve comments.
Jan 15, 2013
f873655
Add 'Reviews' button to main layout.
Jan 15, 2013
48b0a08
Do not show 'Reviews' button unless user is signed in.
Jan 15, 2013
cca42ba
Merge branch 'master' into action
veenstra Jan 16, 2013
d57af88
Populate the 'authors' table with unique commit authors.
veenstra Jan 16, 2013
31efc49
Merge branch 'master' into action
veenstra Jan 16, 2013
3a01ed3
Add author_id field to 'commits' table.
veenstra Jan 16, 2013
999e0b5
Populate the author_id field in the commits table.
veenstra Jan 17, 2013
2203c96
Insert new commit authors into 'authors' table when new commits are i…
veenstra Jan 17, 2013
67f019a
Merge branch 'master' into action
veenstra Jan 17, 2013
3d56362
Link authors to users when they sign in.
veenstra Jan 17, 2013
972db1b
Merge branch 'master' into action
veenstra Jan 17, 2013
31198ce
Modified the migration that populates the author_id field to iterate …
veenstra Jan 17, 2013
4477ed8
Merge branch 'master' into action
veenstra Jan 17, 2013
f850dd5
Add Sequel associations between Author and Commit.
veenstra Jan 18, 2013
c5236b5
Merge branch 'master' into action
veenstra Jan 18, 2013
6c087c0
Fix bug with not showing the Resolve button for the committer.
veenstra Jan 18, 2013
6a4358f
Implement the initial (simple) Reviews view.
veenstra Jan 18, 2013
6322dfc
Create the 'review_requests' table to keep track of code review reque…
veenstra Jan 18, 2013
b9d6c18
Track code review requests in the 'review_requests' table.
veenstra Jan 18, 2013
7743507
Display the list of code review requests.
veenstra Jan 18, 2013
3073bdf
Avoid creating multiple review_request entries for the same review re…
veenstra Jan 19, 2013
14adc7b
Mark a review request as complete when a commit is approved or disapp…
veenstra Jan 19, 2013
c912309
Display code review requests (and recently resolved requests).
veenstra Jan 19, 2013
3b0f969
Add draggable handles to the review lists.
veenstra Jan 19, 2013
1d137c4
Add review_list_order to users table to keep track of list order pref…
veenstra Jan 20, 2013
6c9f9c5
Keep track of review list order.
veenstra Jan 20, 2013
7831667
Refactor models/review_request.rb and add requests_from_me().
veenstra Jan 20, 2013
671640e
Refactor views/reviews.erb and add 'requests from me' list.
veenstra Jan 20, 2013
85bad1c
Show 'None' when a review list becomes empty.
veenstra Jan 20, 2013
96cb6b9
Document the _review_list.erb view and outdent the code. No logic cha…
veenstra Jan 20, 2013
a92009a
Show the 'delete' icon (red X) only for uncompleted review requests.
veenstra Jan 20, 2013
95c91ff
Add a hidden table cell to the unresolved comments list to make it in…
veenstra Jan 20, 2013
16ae97a
Add 'recently resolved comments' list to 'reviews' view.
veenstra Jan 21, 2013
bc9a4b6
Add 'commits with unresolved comments from me' to 'Reviews' view.
veenstra Jan 21, 2013
d0901c6
Remove debugging.
veenstra Jan 21, 2013
052909e
Fix comment in lib/models.rb to replace irrelevant example with a rel…
veenstra Jan 21, 2013
8901f7c
Refactored the views for 'review requests' and 'commits with comments…
veenstra Jan 21, 2013
180b0fb
Add 'Requested at' or 'Completed at' message to review request list.
veenstra Jan 21, 2013
aa380cd
Use server to generate 'recently completed reviews' list after comple…
veenstra Jan 21, 2013
75a4077
Add highlighted labels to the lists on the Reviews page.
veenstra Jan 22, 2013
b2d4410
Better looking labels.
veenstra Jan 22, 2013
10441e9
Add 'closed_at' field to comments. This is the final state of a comment.
veenstra Jan 22, 2013
4b36ec1
Rename comments.completed_at to resolved_at.
veenstra Jan 22, 2013
4afdca0
Implement UI for resolving and closing comments.
veenstra Jan 22, 2013
a040a03
Add an 'Unresolve' button popup when hovering over the comment button…
veenstra Jan 23, 2013
f8158a4
Add 'action_required' to 'comments' table.
veenstra Jan 23, 2013
b2653d4
Add 'Response required' checkbox to comments.
veenstra Jan 23, 2013
45cad0d
Make the 'Preview Comment' button work when editing a comment.
veenstra Jan 23, 2013
d2e6941
Change the color of a comment header to reflect its state (New, Resol…
veenstra Jan 24, 2013
5271590
Change wording from 'Response required' to more polite 'Response requ…
veenstra Jan 24, 2013
dd84c14
Show 'actionable comments' (to-be-resolved and to-be-closed) in Reviews.
veenstra Jan 24, 2013
0317068
Update the comment from the server when changing state (resolving, cl…
veenstra Jan 24, 2013
4ade799
Style changes to reviews.erb for the parameter lists. No logic changes.
veenstra Jan 24, 2013
5906970
Back to 2 visible comment states in the UI.
veenstra Jan 24, 2013
a6509bc
Add helper methods to the comment model for getting the state of a co…
veenstra Jan 25, 2013
99b5ace
Added tags to individual comments and made review lists collapsable.
veenstra Jan 25, 2013
d83852a
Add links to comments in Reviews lists.
veenstra Jan 27, 2013
34646cc
Add lists for pending comments and closed comments.
veenstra Jan 27, 2013
fee8fb5
Hide delete icon in comments list to prevent non-authors from closing…
veenstra Jan 27, 2013
2b0505f
Add zebra striping to commit lists with inline comments.
veenstra Jan 27, 2013
36ce7e6
Show up to 3 comments, then add 'Show all comments' link.
veenstra Jan 27, 2013
da2e8ee
Add paging for review lists.
veenstra Feb 25, 2013
d3ac705
Add indexes to review_requests table.
veenstra Feb 28, 2013
54592ff
Add index for [action_required, closed_at] to comments table.
veenstra Feb 28, 2013
8b020ad
Highlight the commit row above the list of comments.
veenstra Mar 2, 2013
ec71492
Remove commit line in actionable comments when all comments are closed.
veenstra Mar 2, 2013
440ae6b
Fix bug with duplicate rows in review lists and simplify paginate_dat…
veenstra Mar 2, 2013
71e5658
Fix bug with paging.
veenstra Mar 4, 2013
a0c7ada
Make expanding comment lists work correctly.
veenstra Mar 9, 2013
8ad60ca
Refactor commits_with_actionable_comments() to use actionable_comment…
veenstra Mar 10, 2013
2ae9c32
Group related comments within a review list by adding a border.
veenstra Mar 10, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove commit line in actionable comments when all comments are closed.
  • Loading branch information
veenstra committed Mar 2, 2013
commit ec714925f0bf29b7b122028162a45f01ec30ce87
6 changes: 5 additions & 1 deletion public/coffee/reviews.coffee
Original file line number Diff line number Diff line change
@@ -50,8 +50,12 @@ window.Reviews =
comment_id: commentId
}
success: (html) =>
table = target.parents(".innerCommitsList")
count = table.find(".commentRow").size()
target.parents(".commentRow").remove()
# TODO(jack): if no more comments, then remove commit line too
# if that was the last comment, then remove the commit line too
if count == 1
table.parents(".commentEntryRow").remove()
})
false